ci(vscode): allow to fail on oxlint js plugin support test#18779
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 31, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
01-31-ci_vscode_allow_to_fail_on_oxlint_js_plugin_support_test
branch
from
c1dfaa7 to
938c7cd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the VS Code CI pipeline so the oxlint JS plugin support E2E test can run without blocking CI when it fails (treating it as flaky/unstable for now).
Changes:
- Moves the “js plugin support” E2E test into a dedicated spec file and introduces a dedicated test suite (
oxlint-js). - Adds a new
pnpmscript (test:oxlint-js) and VS Code test suite configuration to run only that spec with specific env vars. - Updates the VS Code CI workflow to run the new suite with
continue-on-error: true.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/tests/integration/e2e_server_linter.spec.ts | Removes the JS plugin support test from the main linter E2E suite. |
| editors/vscode/tests/integration/e2e_server_linter-js.spec.ts | Adds a dedicated E2E spec for JS plugin support, gated by an env var. |
| editors/vscode/tests/integration/code_actions.spec.ts | Adds a wait after updating config to reduce timing-related flakiness. |
| editors/vscode/package.json | Adds test:oxlint-js script to run the dedicated suite. |
| editors/vscode/.vscode-test.mjs | Registers new oxlint-js test suite with targeted spec file and env. |
| .github/workflows/ci_vscode.yml | Runs the new test:oxlint-js step as non-blocking (continue-on-error). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
01-31-ci_vscode_allow_to_fail_on_oxlint_js_plugin_support_test
branch
from
938c7cd to
2475d9e
Compare
Member
Author
Merge activity
|
graphite-app
bot
force-pushed
the
01-31-ci_vscode_allow_to_fail_on_oxlint_js_plugin_support_test
branch
from
2475d9e to
25de8fc
Compare
camc314
approved these changes
Jan 31, 2026
graphite-app
bot
deleted the
01-31-ci_vscode_allow_to_fail_on_oxlint_js_plugin_support_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.